Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Research] OUI usage audit in the tile_map plugin #4109

Closed
BSFishy opened this issue May 22, 2023 · 0 comments · Fixed by #4110
Closed

[Research] OUI usage audit in the tile_map plugin #4109

BSFishy opened this issue May 22, 2023 · 0 comments · Fixed by #4110
Assignees
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks OUI Issues that require migration to OUI

Comments

@BSFishy
Copy link
Contributor

BSFishy commented May 22, 2023

Audit

Looking in the tile_map plugin, there are only 2 Sass files. They are src/plugins/tile_map/public/_tile_map.scss and src/plugins/tile_map/public/index.scss. index.scss just imports _tile_map.scss.

_tile_map.scss defines 2 classes:

// SASSTODO: Does this selector exist today?
.tilemap {
  margin-bottom: 6px;
  border: $euiBorderThin;
  position: relative;
}

/**
* 1. Visualizations have some padding by default but tilemaps look nice flush against the edge to maximize viewing
* space.
*/
// SASSTODO: Does this selector exist today?
.tile_map {
  padding: 0; /* 1. */
}

Neither of these classes are actually used anywhere. Commenting them out doesn't change the visual appearance of the visualization at all. Additionally, the className prop isn't used anywhere in the tile_map plugin.

Conclusion

Both of the Sass files can be removed safely.

@BSFishy BSFishy added the OUI Issues that require migration to OUI label May 22, 2023
@BSFishy BSFishy self-assigned this May 22, 2023
@BSFishy BSFishy removed the untriaged label May 22, 2023
@joshuarrrr joshuarrrr added the OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks OUI Issues that require migration to OUI
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants