Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Research] OUI Compliance audit of the vis_default_editor plugin #4096

Open
BSFishy opened this issue May 22, 2023 · 1 comment
Open

[Research] OUI Compliance audit of the vis_default_editor plugin #4096

BSFishy opened this issue May 22, 2023 · 1 comment
Labels
good first issue Good for newcomers OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks OUI Issues that require migration to OUI

Comments

@BSFishy
Copy link
Contributor

BSFishy commented May 22, 2023 •
edited
Loading

Tracking issue for OUI compliance audit of the vis_default_editor plugin.

Follow the steps in #3945 to complete the audit, then open another issue with findings. Once the work of performing the audit is done, this issue can be closed.

Related files
size (bytes) file notes
2.4K src/plugins/vis_default_editor/public/_sidebar.scss
2.0K src/plugins/vis_default_editor/public/_default.scss
223 src/plugins/vis_default_editor/public/_agg.scss
176 src/plugins/vis_default_editor/public/_agg_params.scss
152 src/plugins/vis_default_editor/public/index.scss

If this issue isn't already assigned to someone and you'd like to take on this work, please ping @BSFishy in the comments and I can assign it to you.
@BSFishy BSFishy added OUI Issues that require migration to OUI and removed untriaged labels May 22, 2023
This was referenced May 22, 2023
Open
Open
@seanneumann seanneumann moved this to Todo in Look & Feel May 23, 2023
@BSFishy BSFishy added the good first issue Good for newcomers label May 24, 2023
@joshuarrrr joshuarrrr added the OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks label Jun 1, 2023
@joshuarrrr
Copy link
Member

The styling

OpenSearch-Dashboards/src/plugins/vis_default_editor/public/_sidebar.scss

Lines 29 to 35 in fe1f1d1

.visEditorSidebar__config {
padding: $euiSizeS;
> * {
flex-grow: 0;
}

affects a lot of visualizations (see #4390)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks OUI Issues that require migration to OUI
Projects
Look & Feel
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuarrrr @BSFishy