Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisBuilder] Remove warning popup for vis type change #3647

Closed
ashwin-pc opened this issue Mar 22, 2023 · 0 comments · Fixed by #3715
Closed

[VisBuilder] Remove warning popup for vis type change #3647

ashwin-pc opened this issue Mar 22, 2023 · 0 comments · Fixed by #3715
Assignees

Comments

@ashwin-pc
Copy link
Member

When we change the Visualization type today we also show a popup warning the user that their aggregation settings will not persist. This is no longer true. One of two solution's can be implemented here:

  1. If we know for sure that the new type cannot support all the features of the old type, we should show the popup. Otherwise dont show it
  2. If knowing this is not possible when we switch, prefix the dropdown picker with info to let the user know that there is a chance that their data will not be persisted when they change the vis type and get rid of the popup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants