Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch pkg.branch when build in CI flow #3490

Closed
SuZhou-Joe opened this issue Feb 23, 2023 · 0 comments · Fixed by #3483
Closed

Patch pkg.branch when build in CI flow #3490

SuZhou-Joe opened this issue Feb 23, 2023 · 0 comments · Fixed by #3483
Labels
enhancement New feature or request

Comments

@SuZhou-Joe
Copy link
Member

Is your feature request related to a problem? Please describe.

This is a TODO after PR.

Describe the solution you'd like

Ensure that when build to release, the pkg.branch should be consistent to what the build version is automatically.

Describe alternatives you've considered

Add a lint or pre-check on build process to make sure the pkg.branch property is correctly set according to the branch or build version it is in.

Additional context

PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants