Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Exclude feature branches from cypress test or change branch fetching #3301

Open
joshuarrrr opened this issue Jan 20, 2023 · 2 comments
Open

Comments

@joshuarrrr
Copy link
Member

When it comes to functional tests, we have a chicken/egg problem with new features given the relationship between this repo and https://github.com/opensearch-project/opensearch-dashboards-functional-test. Our current guidance is to add the new feature first, and then add the functional tests. But use of feature branches causes the cypress checkout step to fail:

An example: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/3849044690/jobs/6557561432

Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/feature/feature-anywhere*:refs/remotes/origin/feature/feature-anywhere* +refs/tags/feature/feature-anywhere*:refs/tags/feature/feature-anywhere*
  The process '/usr/bin/git' failed with exit code 1
  Waiting 14 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/feature/feature-anywhere*:refs/remotes/origin/feature/feature-anywhere* +refs/tags/feature/feature-anywhere*:refs/tags/feature/feature-anywhere*
  The process '/usr/bin/git' failed with exit code 1
  Waiting 19 seconds before trying again
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/feature/feature-anywhere*:refs/remotes/origin/feature/feature-anywhere* +refs/tags/feature/feature-anywhere*:refs/tags/feature/feature-anywhere*
@joshuarrrr
Copy link
Member Author

see opensearch-project/opensearch-dashboards-functional-test#469 for proposed solution.

@ashwin-pc
Copy link
Member

I like @kavilla's proposal over excluding the test altogether. Excluding them breaks the main goal of keeping the feature branch on par with the main branch in terms of code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants