-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Update Monaco to a newer version (>= 0.20.0) #3097
Comments
@geckogreen I don't think there are any imminent plans to upgrade it, but a PR would be welcome. Note that As part of the PR, you'd need to provide some research and potentially mitigations for the breaking changes between
Note that any version bump above |
Assuming some of the above changes are breaking, we'd want to do 2 separate PRs for |
alias way has issues because the implementation of monaco-editor has side effects. Please check the Unit test error here. |
I think that aliasing is not done right. |
This is no longer a blocker for the ISM team. It's still something we want to do, but not currently prioritized. |
Currently, OSD is using the monaco editor component in version 0.17.0.
This version is pretty old and we encountered some bugs, in particular
With version 0.20 the API editor.getContentHeight() was added which helps a lot to correctly size the editor if you
use line-wrap.
I would like to propose to update monaco-editor to at least version 0.20.0.
The above mentioned issues seem to be fixed with an upgrade to that version.
Are there already any plans to do this?
If not I could try to provide a pull request.
The text was updated successfully, but these errors were encountered: