Fix type errors in Visualization Builder

[tmarkley]

Task for #1660

PR: (many PRs)

Code owners can you help address this?
@ashwin-pc @abbyhu2000

There were also many instances of implicit any that I temporarily fixed in #3022:

https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3022/files#diff-352c660687bf179d2b9b6571083659d169ceb9333a8e65a6628d7f713133c27e

$ tsc --noEmit
...

src/plugins/vis_builder/public/embeddable/disabled_embeddable.tsx:11:10 - error TS2724: '"./vis_builder_embeddable"' has no exported member named 'VisBuilderInput'. Did you mean 'VisBuilderOutput'?

11 import { VisBuilderInput, VISBUILDER_EMBEDDABLE } from './vis_builder_embeddable';
            ~~~~~~~~~~~~~~~

src/plugins/vis_builder/public/plugin.ts:135:13 - error TS2322: Type 'string | number | boolean | SavedObjectAttributes | SavedObjectAttributeSingle[]' is not assignable to type 'string | undefined'.
  Type 'number' is not assignable to type 'string'.

135             description: attributes?.description!,
                ~~~~~~~~~~~

  src/plugins/visualizations/public/vis_types/vis_type_alias_registry.ts:43:3
    43   description?: string;
         ~~~~~~~~~~~
    The expected type comes from property 'description' which is declared here on type 'VisualizationListItem'

src/plugins/vis_builder/public/plugin.ts:142:13 - error TS2322: Type 'string | number | boolean | SavedObjectAttributes | SavedObjectAttributeSingle[]' is not assignable to type 'string'.
  Type 'number' is not assignable to type 'string'.

142             title: attributes?.title!,
                ~~~~~

  src/plugins/visualizations/public/vis_types/vis_type_alias_registry.ts:42:3
    42   title: string;
         ~~~~~
    The expected type comes from property 'title' which is declared here on type 'VisualizationListItem'

[DaniilShest]

I want to pick up this issue. Most of errors are already solved, but I want to solve this error src/plugins/vis_builder/public/embeddable/disabled_embeddable.tsx:11:10 - error TS2724: '"./vis_builder_embeddable"' has no exported member named 'VisBuilderInput'. Did you mean 'VisBuilderOutput'?
Do I need to create a new Interface something like this?

Am i right?

[DaniilShest]

Can you please take a look on my solution? I created a new Interface in src\plugins\vis_builder\public\embeddable\vis_builder_embeddable.tsx .

And then I replaced an expression in this file: src\plugins\vis_builder\public\embeddable\vis_builder_embeddable_factory.tsx
Is it a right solution?

[ashwin-pc]

@DaniilShest sorry i missed your earlier message, I have a PR coming out for another feature that fixes this too. I forgot to remove the label.