Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Be able to use OUI and EUI #2605

Closed
kavilla opened this issue Oct 18, 2022 · 3 comments
Closed

[BUG] Be able to use OUI and EUI #2605

kavilla opened this issue Oct 18, 2022 · 3 comments
Assignees
@manasvinibs
Labels
bug Something isn't working good first issue Good for newcomers high priority OUI Issues that require migration to OUI ui library Issue or PR related to the UI component library

Comments

@kavilla
Copy link
Member

kavilla commented Oct 18, 2022

We currently alias OUI components to EUI to be non-breaking for developers. But new dev should be implemented in OUI if possible. However the project fails to work when using OUI namespacing.

We should be able to use OUI and EUI within OpenSearch Dashboards.
@kavilla kavilla added bug Something isn't working untriaged ui library Issue or PR related to the UI component library good first issue Good for newcomers high priority labels Oct 18, 2022
@joshuarrrr
Copy link
Member

The PR that aliases it #2080

other aliasing links:
opensearch-project/oui@9abf87e

opensearch-project/oui@2504b43

@manasvinibs
Copy link
Member

@AMoo-Miki @kaddy645 @kavilla Discussion notes: This is not a bug. OUI will be used exclusively in 3.x and we should not be using it along with EUI in 2.x as it will break backporting and plugins compatibility.

@AMoo-Miki
Copy link
Collaborator

We should NOT be using or be able to use the OUI namespacing in OSD 2.x.

@seanneumann seanneumann added the OUI Issues that require migration to OUI label May 19, 2023
@seanneumann seanneumann moved this to Done in Look & Feel May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manasvinibs manasvinibs

Labels
bug Something isn't working good first issue Good for newcomers high priority OUI Issues that require migration to OUI ui library Issue or PR related to the UI component library
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@seanneumann @joshuarrrr @AMoo-Miki @kavilla @manasvinibs