Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add Windows Specific Parameters for just Windows builds #2535

Closed
peterzhuamazon opened this issue Oct 7, 2022 · 6 comments · Fixed by #2601
Closed

[Enhancement] Add Windows Specific Parameters for just Windows builds #2535

peterzhuamazon opened this issue Oct 7, 2022 · 6 comments · Fixed by #2601
Assignees
Labels
enhancement New feature or request windows

Comments

@peterzhuamazon
Copy link
Member

As of now there is no specific params to build windows-only archives.

build the OpenSearch Dashboards distributable

options:
  --skip-archives         Don't produce tar/zip archives
  --skip-os-packages      Don't produce rpm/deb/docker packages
  --all-platforms         Produce archives for all platforms, not just this one
  --linux                 Produce archives for only linux x64 platform
  --linux-arm             Produce archives for only linux arm64 platform
  --darwin                Produce archives for only darwin x64 platform
  --rpm                   Only build the rpm package
  --deb                   Only build the deb package
  --docker                Only build the docker image
  --skip-docker-ubi       Don't build the docker ubi image
  --release               Produce a release-ready distributable
  --version-qualifier     Suffix version with a qualifier
  --skip-node-download    Reuse existing downloads of node.js
  --verbose,-v            Turn on verbose logging
  --no-debug              Turn off debug logging

I am using this comment right now to build all platforms then only take windows.
% yarn build-platform --all-platforms --skip-os-packages --release

It would be really helpful to build only the windows version and also reduce the amount of build time.

Thanks.

@peterzhuamazon
Copy link
Member Author

Hi @opensearch-project/opensearch-dashboards-core could you take a look when you have time?
Thanks!

@joshuarrrr
Copy link
Member

There are a couple other open issues related to windows builds - not sure if either are blockers:

@peterzhuamazon
Copy link
Member Author

There are a couple other open issues related to windows builds - not sure if either are blockers:

* [[Build] De-couple and support to build win32 x64 #796](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/796)

* [Add Windows CI #2451](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2451)

Hi @joshpalis

Our milestone have limit the scope of the new Windows release to 64bit only, x86_64. So the 32bit version is not in the scope right now, as well as arm architecture now.

Thanks.

@kavilla
Copy link
Member

kavilla commented Oct 10, 2022

[Planning]

@seanneumann follow-up on this.

@peterzhuamazon
Copy link
Member Author

With @AMoo-Miki latest change we are able to use --windows to only build windows related artifacts.
Confirmed on the test pipeline through our fork code.

@AMoo-Miki
Copy link
Collaborator

Thanks Peter for confirming. This is fixed by #2601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants