Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VizBuilder] Increase test coverage #2380

Closed
17 of 18 tasks
kavilla opened this issue Sep 16, 2022 · 3 comments
Closed
17 of 18 tasks

[VizBuilder] Increase test coverage #2380

kavilla opened this issue Sep 16, 2022 · 3 comments
Assignees
Labels
v2.5.0 'Issues and PRs related to version v2.5.0' vis builder

Comments

@kavilla
Copy link
Member

kavilla commented Sep 16, 2022

Parent task to fill in the gaps from the low initial coverage that the VisBuilder has.

Sub tasks:

  • Add unit tests to functional code where it makes sense
  • Investigate and document functional testing flow to see if they can be made easier to write and debug
  • Add missing functional test workflows
  • Add Vis Builder FTR tests to OpenSearch Dashboards Repo (set the appropriate env flag)

Missing unit tests

  • src/plugins/wizard/public/application/utils/get_top_nav_config.tsx
  • src/plugins/wizard/public/application/utils/validate_schema_state.ts
  • src/plugins/wizard/public/application/components/data_tab/utils/get_available_fields.ts

Missing functional tests

  • Save workflow
  • View on dashboards
  • Edit from dashboards
  • Create from dashboards:
  • Edit from Visualization listing
  • Metric tests
  • Bar chart tests
  • Line chart tests
  • Area Chart tests
  • Drag and Drop test
  • Change datasource
@kavilla
Copy link
Member Author

kavilla commented Sep 16, 2022

[Follow-up]: Negative code coverage? Maybe we should have a rule if negative code coverage point to new functional tests.

[Follow-up 2]: Is there another way to calculate coverage accurately from a functional tests view point.

@ashwin-pc ashwin-pc changed the title [VizBuilder] Integration Tests [VizBuilder] Increase test coverage Sep 22, 2022
@ashwin-pc ashwin-pc added the v2.5.0 'Issues and PRs related to version v2.5.0' label Nov 23, 2022
@ashwin-pc
Copy link
Member

Save workflow is blocked by #2627 (comment). Will track adding a test workflow as a part of that separately. Closing this issue in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0' vis builder
Projects
None yet
Development

No branches or pull requests

3 participants