Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branding] Remove or allow to disable url validation #1740

Open
ARud12 opened this issue Jun 14, 2022 · 6 comments
Open

[Branding] Remove or allow to disable url validation #1740

ARud12 opened this issue Jun 14, 2022 · 6 comments
Labels
branding enhancement New feature or request

Comments

@ARud12
Copy link

ARud12 commented Jun 14, 2022

How can I remove the URL validation process for the branding icons as well as for the pdf reporting plugin without modifying the source code of OpenSearch Dashboards?

@kavilla kavilla changed the title Remove or allow to disable url validation [Branding] Remove or allow to disable url validation Jun 14, 2022
@kavilla kavilla added enhancement New feature or request branding labels Jun 14, 2022
@kavilla
Copy link
Member

kavilla commented Jun 14, 2022

[Triage]: @ARud12, thanks for opening.

There is currently not a way to do this but we will take this as a feature request.

@ARud12
Copy link
Author

ARud12 commented Jun 15, 2022

Thank you. Will this feature request include both URL validation for the branding icons as well as the pdf reporting plugin?

@joshuarrrr
Copy link
Member

In this repo, we only have control over the branding assets, so it will cover those. I think you can continue the discussion in opensearch-project/reporting#374 (comment) for the reporting plugin pdf validation.

@joshuarrrr
Copy link
Member

I think the best approach to address this use case is an optional config value that allows admins to disable the branding validation checks.

@ARud12
Copy link
Author

ARud12 commented Jun 21, 2022

Yes that will be ideal. What is the estimated waiting time for this feature to be incorporated?

@joshuarrrr
Copy link
Member

We don't currently have this on scheduled to our roadmap, but it will be part of a number of improvements to the branding experience (everything labeled branding ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants