Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change blocklist to denylist to make consistency #1544

Closed
ananzh opened this issue May 3, 2022 · 4 comments · Fixed by #1808
Closed

Change blocklist to denylist to make consistency #1544

ananzh opened this issue May 3, 2022 · 4 comments · Fixed by #1808
Assignees
Labels

Comments

@ananzh
Copy link
Member

ananzh commented May 3, 2022

In this OpenSearch PR:

Replace the old usages that having "blacklist/whitelist" in configurations with "denylist/allowlist", then create duplicate usages with the old terminology for backwards compatibility (including fallback logic to fallback to settings with the new name).

There are several references to blocklist in the core dashboards repo. One customer facing example is for the Graphite blocklist feature. To make consistency, we should replaced blocklist to denylist, including something related, for example graphiteBlockedIPs.

This should not break anything. It is just for code consistency purpose.

@ananzh ananzh added bug Something isn't working untriaged and removed untriaged labels May 3, 2022
@tmarkley
Copy link
Contributor

tmarkley commented May 3, 2022

Is this a duplicate of #1319?

@joshuarrrr
Copy link
Member

I think the intent is that blocklist terminology should also be updated to denylist, in addition to the blacklist -> denylist change covered by #1319

@tmarkley
Copy link
Contributor

tmarkley commented May 9, 2022

@joshuarrrr ahhh right, my brain was glossing over that when I first read it 😄

@kavilla
Copy link
Member

kavilla commented Jun 29, 2022

Removing 2.1 label due to code cutoff being today.

@kavilla kavilla added v2.2.0 and removed v2.1.0 labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants