[Enhancement] Update ci workflow so Dashboards will actually test SNAPSHOT and QUALIFIER

[peterzhuamazon]

Hi,

As of now we skip the checks for snapshots and qualifier in ci workflow for dashboards due to it is checking package.json.
These information are not in package.json thus cannot check.

https://github.com/opensearch-project/opensearch-build/blob/main/src/ci_workflow/ci_check_npm_package_version.py#L16-L18

We need a method similar to gradle properties for yarn or some other ways to properly extract these values for ci checks.

Thanks.

[dblock]

Isn't the problem that package.json needs to have the snapshot and qualifier information? @kavilla

[dblock]

Is this still 2.0?

[peterzhuamazon]

Is this still 2.0?

I dont think it is 2.0 required but would be nice to get it 😄

[gaiksaya]

[Triage] Hey @opensearch-project/opensearch-dashboards-core, can someone look into this to support qualifier and snapshot via yarn?
Thanks!

[kavilla]

Hello!

So the ask here is to have other keys? I do believe when the package.json is build with snapshot or qualifer the version key will have that information.

[peterzhuamazon]

Hello!

So the ask here is to have other keys? I do believe when the package.json is build with snapshot or qualifer the version key will have that information.

That means you need to 1st build it with the snapshot/qualifier, which is not how the manifest workflow is trying to achieve.
The workflow is trying to identify the versions already in the repo, and check if any manifest missing for it.