From d7465957c89ac26c6c2c0366bba696e905309c3a Mon Sep 17 00:00:00 2001 From: Miki Date: Wed, 12 Jul 2023 14:09:28 -0700 Subject: [PATCH] Fix Node.js download link (#4556) https://mirrors.nodejs.org/ is no longer available which prevents the ability from release builds being made. Restoring back the original link. Follow-up should be considered about a caching mechanism and param to the CLI to utilize another link or path. Signed-off-by: Miki --- CHANGELOG.md | 1 + src/dev/build/tasks/nodejs/node_download_info.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cfdb7161dcf3..cb7f3da8747e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [Saved Objects Management] Fix relationships header overflow ([#4070](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4070)) - Update main menu to display 'Dashboards' for consistency ([#4453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4453)) - [Multiple DataSource] Retain the original sample data API ([#4526](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4526)) +- Fix Node.js download link ([#4556](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4556)) ### 🚞 Infrastructure diff --git a/src/dev/build/tasks/nodejs/node_download_info.ts b/src/dev/build/tasks/nodejs/node_download_info.ts index 37eba4c29a58..d0fefe72e7c8 100644 --- a/src/dev/build/tasks/nodejs/node_download_info.ts +++ b/src/dev/build/tasks/nodejs/node_download_info.ts @@ -46,7 +46,7 @@ export async function getNodeDownloadInfo(config: Config, platform: Platform) { ? `node-v${version}-win-x64.zip` : `node-v${version}-${arch}.tar.gz`; - const url = `https://mirrors.nodejs.org/dist/v${version}/${downloadName}`; + const url = `https://nodejs.org/dist/v${version}/${downloadName}`; const downloadPath = config.resolveFromRepo('.node_binaries', version, basename(downloadName)); const extractDir = config.resolveFromRepo('.node_binaries', version, arch); @@ -69,7 +69,7 @@ export async function getNodeVersionDownloadInfo( ? `node-v${version}-win-x64.zip` : `node-v${version}-${architecture}.tar.gz`; - const url = `https://mirrors.nodejs.org/dist/v${version}/${downloadName}`; + const url = `https://nodejs.org/dist/v${version}/${downloadName}`; const downloadPath = resolve(repoRoot, '.node_binaries', version, basename(downloadName)); const extractDir = resolve(repoRoot, '.node_binaries', version, architecture);