From 8396f9d19bc191f5f38fe3aa62ddb544956ba40e Mon Sep 17 00:00:00 2001
From: Aleksandar Djindjic <djindjic@gmail.com>
Date: Sun, 22 Jan 2023 14:05:48 +0100
Subject: [PATCH] Improved typings

Passing this first param to `CoreSetup` generic would set a proper type to `depsStart` returned from `core.getStartServices()`

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
---
 src/core/CONVENTIONS.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/core/CONVENTIONS.md b/src/core/CONVENTIONS.md
index 5d24b54d9920..fff8282b42da 100644
--- a/src/core/CONVENTIONS.md
+++ b/src/core/CONVENTIONS.md
@@ -182,10 +182,10 @@ export const renderApp = (
 ```ts
 // my_plugin/public/plugin.ts
 
-import { Plugin } from '../../src/core/public';
+import { Plugin, CoreSetup } from '../../src/core/public';
 
 export class MyPlugin implements Plugin {
-  public setup(core) {
+  public setup(core: CoreSetup<MyPluginDepsStart>) {
     core.application.register({
       id: 'my-app',
       async mount(params) {