Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote notebook install instructions in README #16

Closed
ashiklom opened this issue Oct 23, 2020 · 2 comments · Fixed by #21
Closed

Quote notebook install instructions in README #16

ashiklom opened this issue Oct 23, 2020 · 2 comments · Fixed by #21

Comments

@ashiklom
Copy link

bash doesn't seem to mind hard brackets, but zsh (note: the default shell on recent MacOS) doesn't like them in unquoted form and throws the following error:

zsh: no matches found: openscm-twolayermodel[notebooks]

This is easily resolved by quoting the full package name:

pip install "openscm-twolayermodel[notebooks]"

I would suggest tweaking this in the installation docs.

(Discovered as part of openjournals/joss-reviews#2766).

@ashiklom ashiklom changed the title Quote notebook instructions in README Quote notebook install instructions in README Oct 23, 2020
@znicholls
Copy link
Contributor

znicholls commented Oct 31, 2020

Awesome thanks! I've put a fix in #21 if you want to take a look

@ashiklom
Copy link
Author

ashiklom commented Nov 2, 2020

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants