Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History in Lobby #28

Open
TheRaphael0000 opened this issue Mar 23, 2019 · 0 comments
Open

History in Lobby #28

TheRaphael0000 opened this issue Mar 23, 2019 · 0 comments
Labels
enhancement New feature or request invalid This doesn't seem right Technical Things that don't change to usability but improves the implementation quality

Comments

@TheRaphael0000
Copy link
Collaborator

History isn't handeled in the best way.

Currently :

  • The history is send at the same time as the scoreboard (this message is send too many times, each time someone find the answer)
  • People who joined during the game can watch the full history (and make reports on unseen sauces)
  • There is a route that gather informations on a certain sauce without authentication (to load the question when opening the modal for the report)

Todo :

  • The history should be only handeld by the client (in js), not send anymore in the scoreboard
  • Remove the route for the gathering informations on the report
@TheRaphael0000 TheRaphael0000 added enhancement New feature or request invalid This doesn't seem right labels Mar 23, 2019
@damianpetroff damianpetroff added the Technical Things that don't change to usability but improves the implementation quality label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right Technical Things that don't change to usability but improves the implementation quality
Projects
None yet
Development

No branches or pull requests

2 participants