Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate docker image tag is valid #291

Open
bloodearnest opened this issue May 2, 2024 · 1 comment
Open

Validate docker image tag is valid #291

bloodearnest opened this issue May 2, 2024 · 1 comment

Comments

@bloodearnest
Copy link
Member

bloodearnest commented May 2, 2024

A user recently typo'd a few of their run commands like so:

run: r:analysis/data_prep_descrip.R

This mean the image name was parsed as r:analysis/data_prep_descrip.R rather than r, and produced an INTERNAL_ERROR

We should validate when parsing the yaml that the tag for images is valid. This will likely either mean figuring out explicit valid versions, or possibly more simply using a regex validation of the tag to match something like v\d{\.\d}*?

Context: https://bennettoxford.slack.com/archives/C01D7H9LYKB/p1714559913897309

@evansd
Copy link
Contributor

evansd commented May 2, 2024

Ah, I created an issue for this already but probably on the wrong repo in retrospect:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants