Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider increasing DATA_UPLOAD_MAX_NUMBER_FIELDS setting #4752

Open
evansd opened this issue Nov 28, 2024 · 0 comments
Open

Consider increasing DATA_UPLOAD_MAX_NUMBER_FIELDS setting #4752

evansd opened this issue Nov 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@evansd
Copy link
Contributor

evansd commented Nov 28, 2024

There turns out to be another barrier to dispatching a large number of jobs which is that by default Django won't accept more than 1,000 checkbox inputs and will throw a TooManyFieldsSent error.

Em hit this error recently (presumably as a result of using my hacky JS thing to select a lot of checkboxes):
https://ebm-datalab.sentry.io/issues/6090198345/

The Django docs suggest that "applications that are expected to receive an unusually large number of form fields should tune this setting." I think it would be reasonable to increase it, maybe to a couple of thousand. Because of the existence of "run all" it doesn't act as a hard barrier to prevent users from dispatching too many jobs in any case.

@lucyb lucyb added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants