Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit release file size in API #3555

Closed
bloodearnest opened this issue Sep 13, 2023 · 1 comment · Fixed by #3579
Closed

Limit release file size in API #3555

bloodearnest opened this issue Sep 13, 2023 · 1 comment · Fixed by #3579
Assignees
Labels

Comments

@bloodearnest
Copy link
Member

bloodearnest commented Sep 13, 2023

We should limit the uploaded file size the release API.

This probably should be limited in both the release request creation (returning a 400 error) and also the upload api (returning 413 - possibly implemented in nginx?)

A sensible starting default might be 16mb, and then see if there are any complaints with that. We should look at existing released file size to check.

Care needs to be taken to communicate this change in output-checking process.

@ghickman
Copy link
Contributor

We have released 10409 files so far.

Which are distributed like so:

Size range Count
<1Mb 9812
>=1<2 309
>=2<3 77
>=3<4 19
>=4<5 16
>=5<6 14
>=6<7 12
>=7<8 17
>=8<9 10
>=9<10 5
>=10<11 4
>=11<12 0
>=12<13 2
>=13<14 4
>=14<15 3
>=15<16 3
>=16<17 2
>=16Mb 19

The files over 16 Mb are a bit of a mixed bag:

88.27Mb
49.54Mb
39.73Mb
29.12Mb
25.21Mb
24.0Mb
23.97Mb
23.94Mb
23.92Mb
23.28Mb
22.78Mb
20.04Mb
19.72Mb
17.91Mb
17.88Mb
17.62Mb
17.41Mb
16.91Mb
16.89Mb

Based on these numbers 16Mb seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants