Test Views Render Templates

[ghickman]

#1181 showed that we weren't testing the configured template existed. Ideally we wouldn't require each view had a unit test for this as it's easily prone to human error.

Can we add a test with subtests which tries to exercise response.rendered_content for every view that responds to GET and with a 200?

[inglesp]

Ideally we wouldn't require each view had a unit test for this as it's easily prone to human error.

Are you saying that request factory tests don't actually render the template?

[ghickman]

Correct, you have to access rendered_content to get the rendered output.

[inglesp]

Yikes. Feels like a bit of a shortcoming in request factories. Could we make our own request factory that automatically calls rendered_content?

[ghickman]

If you're used to using Client, maybe? RequestFactory generates a request, nothing more. You then use that to test a view with. Views, GCBVs in particular, do not render content by default, they instantiate the configured response class (typically TemplateResponse) and return that instance.

I'd rather we didn't have every unit test render templates, that's going to eat up quite a bit of test time.

[inglesp]

Could we make our own request factory that automatically calls rendered_content?

I see now that this couldn't work!

Have you seen https://github.com/nedbat/django_coverage_plugin?

[ghickman]

I haven't, happy to give it a go though!

[inglesp]

FWIW I just ran:

sed -i 's/status_code == 200/rendered_content is not None/' tests/unit/*/views/*

This changed 95 tests, and the time to run the full suite did not change.

[ghickman]

That is very unexpected, but good to know, can you do that same sed, but add the rendered content check after the 200 so we get both?