Fix obsolete outputs bug tests #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
madwort
commented
Oct 4, 2024
•
madwort
commented
- fixes get_obsolete_files() not functioning #750
madwort
force-pushed
the
madwort/obselete-outputs-issue
branch
2 times, most recently
from
894dd65 to
d93f2eb
Compare
madwort
commented
Oct 4, 2024
jobrunner/queries.py
Outdated
| # Remove running jobs from the list - this function is used to compare a | ||
| # job to a previously completed job, if we include running jobs here | ||
| # we will compare a job to itself (with hilarious consequences!) | ||
| jobs = filter(lambda x: x.state != State.RUNNING, jobs) |
There was a problem hiding this comment.
this breaks a ton of other stuff!
madwort
force-pushed
the
madwort/obselete-outputs-issue
branch
from
c97df18 to
caf078b
Compare
|
most of this is in #755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.