Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dummy_tables_path optional for starting the ehrQL sandbox #2187

Closed
wants to merge 4 commits into from
Closed

Make dummy_tables_path optional for starting the ehrQL sandbox #2187

wants to merge 4 commits into from

Conversation

alarthast
Copy link
Contributor

@alarthast alarthast commented Oct 24, 2024 •
edited
Loading

Fixes #2184.

  • Make the sandbox command default to using example-data if dummy_tables_path is not provided.
  • If example-data does not exist, ask to dump it in the current directory (rationale in the ticket).
  • To preserve the existing syntax, dummy_tables_path is an optional positional argument, so update cli.py to accommodate this.
  • Add a banner message at the beginning of the sandbox stating the location of the dummy tables used, now that this is not an explicit argument for starting the sandbox. This replaces the default InteractiveConsole banner message.

@alarthast
Copy link
Contributor Author

Closed since we are likely going to be replacing the sandbox with marimo notebooks

@alarthast alarthast closed this Oct 25, 2024
@alarthast alarthast mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dummy_tables_path optional for starting the ehrQL sandbox
1 participant
@alarthast