Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define criteria for tables/columns to be provided in example-data CSV files #2146

Closed
alarthast opened this issue Oct 8, 2024 · 1 comment · Fixed by #2180
Closed

Define criteria for tables/columns to be provided in example-data CSV files #2146

alarthast opened this issue Oct 8, 2024 · 1 comment · Fixed by #2180
Assignees

Comments

@alarthast
Copy link
Contributor

alarthast commented Oct 8, 2024

  • See Slack conversion and this comment in Fix capitalisation in example data #2143.
  • Currently it is unclear what tables should be included as CSV files in the example data. @evansd suggested that all core tables + all tables used in the tutorial would make sense
    • If so, we should add a CSV file representing the tpp.apcs table
  • Once the criteria is set, the test file for example data should be updated to remove the hard-coding of tables.
  • We should also look at whether our example CSV files ought to include all the columns of the tables they represent
    • If so, add the columns and use allow_missing_columns=False in the tests
@evansd
Copy link
Contributor

evansd commented Oct 22, 2024

We've decided to take the approach of:

  1. expanding the core tables to include practice_registrations;
  2. rewriting the more complex tutorial definition to only use core tables.

This allows us to make the policy very simple:

  • The tutorial examples should only use core tables.
  • We should provide example data for all core tables.

@alarthast alarthast changed the title Define criteria for tables/columns to be provided in example-table CSV files Define criteria for tables/columns to be provided in example-data CSV files Dec 4, 2024
@inglesp inglesp pinned this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants