Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to reusable action #7

Closed
LFISHER7 opened this issue Jan 26, 2024 · 10 comments · Fixed by opensafely-actions/project-dag#2
Closed

Convert to reusable action #7

LFISHER7 opened this issue Jan 26, 2024 · 10 comments · Fixed by opensafely-actions/project-dag#2
Assignees
Labels
help wanted Extra attention is needed

Comments

@LFISHER7
Copy link

I'd like to convert my study into a reusable action. My study is in this repo:

https://github.com/opensafely/project-dag

@LFISHER7 LFISHER7 added the help wanted Extra attention is needed label Jan 26, 2024
@iaindillingham
Copy link
Member

Thanks, @LFISHER7. I've added this issue to the board. You can follow progress there.

@lucyb
Copy link

lucyb commented Feb 8, 2024

@sebbacon has suggested making this into a reusable GitHub Action that would be run whenever a project.yaml has changed. How would you both feel about that, would it be more useful there?

@iaindillingham
Copy link
Member

That seems like a good idea. Where would we surface the diagram? (Or is that TBD?)

@LFISHER7
Copy link
Author

LFISHER7 commented Feb 8, 2024

Yes, that sounds good. I think the most useful place to surface it is in the readme, which I think means outputting the diagram as an image rather than md

@lucyb
Copy link

lucyb commented Feb 8, 2024

Could you just save it as a CI workflow artefact to start with? Would people know to look there?

@LFISHER7
Copy link
Author

LFISHER7 commented Feb 8, 2024

I don't think they would. If it isn't fully automated then I don't think there's sufficient value add over a reusable action

@lucyb
Copy link

lucyb commented Feb 13, 2024

Jon has also suggested this could be an option in the CLI. However, we've decided that we'll create the reusable action and use that to learn more about how we might use this feature in future.

@iaindillingham
Copy link
Member

There's a short Slack thread.1

Footnotes

  1. https://bennettoxford.slack.com/archives/C069SADHP1Q/p1708956506714339

@iaindillingham
Copy link
Member

I've converted this to a reusable action, @LFISHER7. v0.0.1 was tagged automatically; for more information, please see DEVELOPERS.md.

@LFISHER7
Copy link
Author

Thanks for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants