Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is extremely brittle due to usage of latest.release #1508

Closed
gsmet opened this issue Mar 27, 2022 · 3 comments
Closed

Build is extremely brittle due to usage of latest.release #1508

gsmet opened this issue Mar 27, 2022 · 3 comments

Comments

@gsmet
Copy link
Contributor

gsmet commented Mar 27, 2022

Hi,

I had two build issues trying to build OpenRewrite lately:

This, without any change on my side.

This all boils down to the massive use of latest.release as the version of dependencies in the codebase which makes builds non reproducible and very brittle as soon as the latest release has problems or incompatibility issues with the codebase.
Wondering if it would be better to switch to hardcoded versions and using Dependabot to suggest the updates automatically?

That should make the builds more solid and at least a build of the exact same code would lead to the same result from one day to another.

@shanman190
Copy link
Contributor

Related #1484

@tkvangorder
Copy link
Contributor

Going to close this issue as a duplicate of #1484

@tkvangorder tkvangorder moved this to Done in OpenRewrite Mar 28, 2022
@jkschneider jkschneider reopened this Mar 28, 2022
Repository owner moved this from Done to Backlog in OpenRewrite Mar 28, 2022
@jkschneider
Copy link
Member

We can commit to once-a-day dependency locking, but we will not rely on Dependabot as it is not nearly sophisticated enough to deal with Gradle dependency management. We can craft a Github action workflow to attempt to update dependencies once a day, and if the tests pass, commit the new lock.

Repository owner moved this from Backlog to Done in OpenRewrite Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants