Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model path argument to scGPT #16

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Dec 9, 2024

Describe your changes

Adds a model_path argument the the scGPT model which allows using a local model directory rather than downloading it.

Fixes #14

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood December 9, 2024 09:08
@lazappi lazappi mentioned this pull request Dec 10, 2024
8 tasks
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that I'd rename the arguments :)

src/methods/scgpt/config.vsh.yaml Outdated Show resolved Hide resolved
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lazappi lazappi merged commit dd18949 into main Dec 10, 2024
2 checks passed
lazappi added a commit that referenced this pull request Dec 10, 2024
…GPT-finetuned

* origin/main:
  Add argument to give model path to scGPT (#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scGPT model
2 participants