Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batch_int] Revamp control methods #285

Open
rcannood opened this issue Nov 16, 2023 · 3 comments
Open

[batch_int] Revamp control methods #285

rcannood opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@rcannood
Copy link
Member

The OpenProblems v1 repo has the following control methods:

  • No integration (Simply return PCA embedding)
  • Random integration:
    • Permute features
    • Permute graph
    • Permute PCA embedding
  • Permute per celltype
    • Permute features within cell types
    • Permute graph within cell types
    • Permute embedding within cell types
  • Permute per batch
    • Same
@rcannood rcannood added the enhancement New feature or request label Nov 16, 2023
@rcannood
Copy link
Member Author

Defining negative control methods is easy -- simply permuting the features, graph or PCA embedding should do the trick. To define the positive control, we'll need to take a look at how to define positive controls to target specific metrics.

This was already done in v1 -- we should look for the discussion on how this was tackled in the v1.

@mumichae
Copy link
Collaborator

Going off what we have on the v1 website, these are all batch integration baselines:

image

Out of these, we're currently missing:

  • No integration
  • Random integration by cell type
  • Random integration by batch
  • Random graph by cell type

@mumichae
Copy link
Collaborator

From what I can see the control methods are not organised in the same hierarchy that you listed here @rcannood, but I think it might be useful to do that, so we don't get confused with the naming. This will require reorganising the v1 code as well as the number of the control methods, unless we come up with a way to compute a method and process the different outputs (feature, embedding, graph) differently based on 1 outcome, complicating things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants