Fix ajax filtering for the map markers on proposals #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #39 |
2 tasks
This was
linked to
issues
Oct 19, 2022
1 task
microstudi
requested changes
Oct 19, 2022
There was a problem hiding this comment.
Thanks @antopalidi, this is great!
In order to be super-duper excellent we should add a test to this.
I think we can add a case in the file decidim-proposals/spec/systemindex_proposals_spec.rb to check that the markerData has the corresponding filtered content.
it would be something like
context "when there are filters" do
it "has proposals in markerData" do
visit_component
expect(page.body).to have_content("here some content that should appear in the json")
end
it "has no proposals in markerData on filtering" do
visit_component
uncheck "Accepted"
expect(page.body).to have_content("here some content that should appear in the json")
end
end
microstudi
changed the title
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video-1.mov