Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server crashes at random intervals #818

Closed
bakunawa01 opened this issue Dec 28, 2023 · 5 comments
Closed

Server crashes at random intervals #818

bakunawa01 opened this issue Dec 28, 2023 · 5 comments
Assignees
Labels
bug Something isn't working nightly

Comments

@bakunawa01
Copy link

bakunawa01 commented Dec 28, 2023

Describe the bug
The server is crashing with something that seems to be raknet/network related. We've noticed that prior to a crash, we're getting an error coming from Pawn.Raknet with an invalid playerid (-1) on OnIncomingPacket. We've tried disabling includes that uses the native but the problem still persists (Folder 5 of the file attached).

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots and/or logs
This is from one of the crash
[12:46:24] Run time error 4: "Array index out of bounds" [12:46:24] Attempted to read/write array element at negative index -1 [12:46:24] AMX backtrace: [12:46:24] #0 000a23d8 in public OnIncomingPacket (-1, 30, 8321028) in <unknown> [12:46:24] Run time error 4: "Array index out of bounds" [12:46:24] Attempted to read/write array element at negative index -1 [12:46:24] AMX backtrace: [12:46:24] #0 000a23d8 in public OnIncomingPacket (-1, 41, 8321028) in <unknown> [12:46:24] Run time error 4: "Array index out of bounds" [12:46:24] Attempted to read/write array element at negative index -1 [12:46:24] AMX backtrace: [12:46:24] #0 000a23d8 in public OnIncomingPacket (-1, 220, 8321028) in <unknown> [12:46:24] Run time error 4: "Array index out of bounds" [12:46:24] Attempted to read/write array element at negative index -1 [12:46:24] AMX backtrace: [12:46:24] #0 000a23d8 in public OnIncomingPacket (-1, 221, 8321028) in <unknown> [12:46:24] Run time error 4: "Array index out of bounds" [12:46:24] Attempted to read/write array element at negative index -1 [12:46:24] AMX backtrace: [12:46:24] #0 006712cc in public pr_ip_221 (-1, 8321028) in <unknown> [12:46:27] Run time error 4: "Array index out of bounds" [12:46:27] Attempted to read/write array element at negative index -1 [12:46:27] AMX backtrace: [12:46:27] #0 000a24d8 in public OnIncomingRPC (-1, 155, 8319552) in <unknown> [12:46:27] Server crashed due to an unknown error [12:46:27] Registers: [12:46:27] EAX: 010f2ab4 EBX: 027652d0 ECX: 027652d0 EDX: 2fd5cfec [12:46:27] ESI: 007ef21c EDI: 007ef0c0 EBP: 007ef1f8 ESP: 007ef0bc [12:46:27] EIP: 00000000 EFLAGS: 00210202 [12:46:27] Stack: [12:46:27] ESP+00000000: 00ef2101 00002440 00004160 00000000 [12:46:27] ESP+00000020: 00000900 00006000 01003100 3e000000 [12:46:27] ESP+00000040: 2f000000 18000000 00000100 00010100 [12:46:27] ESP+00000060: 00003500 05000a00 90000000 52000001 [12:46:27] ESP+00000080: 09000000 00000d00 00003500 1e005500 [12:46:27] ESP+000000a0: 05006300 2e000000 4c000000 00000800 [12:46:27] ESP+000000c0: 00000b00 00003b00 01006d00 61000000 [12:46:27] ESP+000000e0: 2e000000 17000000 00002000 00002e00 [12:46:27] ESP+00000100: 00002e00 05002c00 69000000 49000000 [12:46:27] ESP+00000120: 007ef0c0 007ef368 00f70780 00000000 [12:46:27] ESP+00000140: 00ef205e 007ef21c 027652d0 10939f9b [12:46:27] ESP+00000160: 02872950 b8ad66c7 007ef240 00121108 [12:46:27] ESP+00000180: 007ef240 00000000 00000800 00000000 [12:46:27] ESP+000001a0: 77124dd7 00000000 007ef334 0000004d [12:46:27] ESP+000001c0: 007ef2a8 71b29e4a 9fe79927 138dbfa8 [12:46:27] ESP+000001e0: 00000000 05303878 00000000 00000002 [12:46:27] ESP+00000200: 71b288d9 71b288e3 9fe7993f 13900458 [12:46:27] ESP+00000220: 1a021d6c 000244b8 0000004d 2e5d63de [12:46:27] ESP+00000240: 0000ffff 00000000 770d5bc4 00000001 [12:46:27] ESP+00000260: 2e5d625a 007ef3a0 c0000139 c0000100 [12:46:27] ESP+00000280: 007ef3b4 00000000 00000001 00000004 [12:46:27] ESP+000002a0: 03ba7298 03ba72a0 007ef240 007ef610 [12:46:27] ESP+000002c0: 43e1f878 007ef638 72144931 007ef3b0 [12:46:27] ESP+000002e0: 0013cf20 d4bfc441 00000000 45030000 [12:46:27] ESP+00000300: 00007b83 b7d00074 0013c70c 007ef4ec [12:46:27] ESP+00000320: 00000020 00000018 443d1208 030fe500 [12:46:27] ESP+00000340: 00000000 766b542d 030fe5cc 00000000 [12:46:27] ESP+00000360: 00000000 0000003c 00000000 007ef490 [12:46:27] ESP+00000380: 00000000 007ef468 000fe5a8 007ef470 [12:46:27] ESP+000003a0: 00000000 00000000 658c1ca3 72063370 [12:46:27] ESP+000003c0: 05f9edc8 0000008e 05f9edc8 007ef040 [12:46:27] ESP+000003e0: 9fe79f3f 138dbfa8 05f9edc8 00000000 [12:46:27] Loaded modules: [12:46:27] 00eb0000 - 01190000 omp-server.exe [12:46:27] 770a0000 - 7723d000 ntdll.dll [12:46:27] 749f0000 - 74ad0000 KERNEL32.DLL [12:46:27] 76760000 - 76961000 KERNELBASE.dll [12:46:27] 751e0000 - 7523f000 WS2_32.dll [12:46:27] 75340000 - 753fd000 RPCRT4.dll [12:46:27] 746c0000 - 746e0000 SspiCli.dll [12:46:27] 746b0000 - 746ba000 CRYPTBASE.dll [12:46:27] 752b0000 - 75315000 bcryptPrimitives.dll [12:46:27] 74c90000 - 74d09000 sechost.dll [12:46:27] 758d0000 - 75e25000 SHELL32.dll [12:46:27] 74b30000 - 74bf0000 msvcrt.dll [12:46:27] 76da0000 - 76ddb000 cfgmgr32.dll [12:46:27] 76630000 - 76753000 ucrtbase.dll [12:46:27] 75840000 - 758c9000 shcore.dll [12:46:27] 74770000 - 749e2000 combase.dll [12:46:27] 75e30000 - 7642d000 windows.storage.dll [12:46:27] 76de0000 - 76e60000 msvcp_win.dll [12:46:27] 76d10000 - 76d90000 advapi32.dll [12:46:27] 74d60000 - 74d7c000 profapi.dll [12:46:27] 74ad0000 - 74b24000 powrprof.dll [12:46:27] 76e60000 - 76ea4000 shlwapi.dll [12:46:27] 746e0000 - 74704000 GDI32.dll [12:46:27] 756c0000 - 75834000 gdi32full.dll [12:46:27] 754f0000 - 7568a000 USER32.dll [12:46:27] 76b70000 - 76b87000 win32u.dll [12:46:27] 76d90000 - 76d9f000 kernel.appcore.dll [12:46:27] 76b50000 - 76b65000 cryptsp.dll [12:46:27] 76970000 - 76b2f000 CRYPT32.dll [12:46:27] 75240000 - 7524e000 MSASN1.dll [12:46:27] 76b30000 - 76b49000 bcrypt.dll [12:46:27] 74680000 - 746a4000 WINMM.dll [12:46:27] 723a0000 - 7240d000 MSVCP140.dll [12:46:27] 74610000 - 74625000 VCRUNTIME140.dll [12:46:27] 745c0000 - 745e3000 WINMMBASE.dll [12:46:27] 75690000 - 756b5000 IMM32.DLL [12:46:27] 744b0000 - 744d2000 Actors.dll [12:46:27] 745f0000 - 7460c000 Checkpoints.dll [12:46:27] 74490000 - 744af000 Classes.dll [12:46:27] 73ce0000 - 73d11000 Console.dll [12:46:27] 72330000 - 7239c000 CustomModels.dll [12:46:27] 72260000 - 72327000 Databases.dll [12:46:27] 72240000 - 7225d000 Dialogs.dll [12:46:27] 72220000 - 7223f000 Fixes.dll [12:46:27] 721f0000 - 72211000 GangZones.dll [12:46:27] 721c0000 - 721e5000 LegacyConfig.dll [12:46:27] 72110000 - 721bb000 LegacyNetwork.dll [12:46:27] 720e0000 - 72101000 Menus.dll [12:46:27] 720a0000 - 720d2000 Objects.dll [12:46:27] 71f00000 - 7209b000 Pawn.dll [12:46:27] 71e50000 - 71ef4000 pawncmd.dll [12:46:27] 71d30000 - 71dc7000 pawnraknet.dll [12:46:27] 71d00000 - 71d21000 Pickups.dll [12:46:27] 71cd0000 - 71cf9000 Recordings.dll [12:46:27] 71c30000 - 71cd0000 sampvoice.dll [12:46:27] 71c00000 - 71c25000 TextDraws.dll [12:46:27] 71bd0000 - 71bf4000 TextLabels.dll [12:46:27] 71e30000 - 71e49000 Timers.dll [12:46:27] 0f650000 - 112fc000 Unicode.dll [12:46:27] 71bb0000 - 71bcd000 Variables.dll [12:46:27] 71b80000 - 71baf000 Vehicles.dll [12:46:27] 71dd0000 - 71e22000 mswsock.dll [12:46:27] 71b20000 - 71b7c000 crashdetect.dll [12:46:27] 71ad0000 - 71b1f000 audio.dll [12:46:27] 71a60000 - 71ac9000 MSVCP100.dll [12:46:27] 717c0000 - 7187f000 MSVCR100.dll [12:46:27] 71a10000 - 71a5c000 streamer.dll [12:46:27] 71770000 - 717be000 mysql.dll [12:46:27] 71750000 - 7176a000 log-core.dll [12:46:27] 0f110000 - 0f1dd000 libmariadb.dll [12:46:27] 74470000 - 7447a000 Secur32.dll [12:46:27] 71730000 - 71741000 napinsp.dll [12:46:27] 71900000 - 71991000 DNSAPI.dll [12:46:27] 74bf0000 - 74bf7000 NSI.dll [12:46:27] 718c0000 - 718f3000 IPHLPAPI.DLL [12:46:27] 74480000 - 7448b000 winrnr.dll [12:46:27] 500b0000 - 500c6000 NLAapi.dll [12:46:27] 71a00000 - 71a10000 wshbth.dll [12:46:27] 71880000 - 71888000 rasadhlp.dll [12:46:27] 0f0e0000 - 0f0ee000 sscanf.dll [12:46:27] 0f320000 - 0f32c000 Whirlpool.dll [12:46:27] 77a60000 - 77afb000 MSVCR80.dll [12:46:27] 0f340000 - 0f3e9000 SAMP-WebSockets.dll [12:46:27] 716d0000 - 71721000 fwpuclnt.dll

Commit hash in master
https://github.com/openmultiplayer/open.mp/tree/ceede7331cfccbda4c81dcee442499e0d37c3db1

omp-dumps.zip

@bakunawa01 bakunawa01 added bug Something isn't working nightly labels Dec 28, 2023
@NexiusTailer
Copy link
Contributor

Looks like pawn.raknet calls OnIncomingPacket with playerid -1, but do it only under omp server.

@BeckzyBoi
Copy link

I've experienced this before too. I mentioned it earlier in the year:

https://discord.com/channels/231799104731217931/231799180127895553/1120197553003188396

@NexiusTailer
Copy link
Contributor

The thing is that it's not possible under samp server because it was fixed years ago, here:
https://github.com/katursis/Pawn.RakNet/releases/tag/1.3.0

and it literally added a check for playerid being -1 in some of those commits before 1.3.0 was released. So, thus the problem seems to be only relevant under omp server.

@AmyrAhmady
Copy link
Member

I see, this helps a lot. seems like when pawn.raknet was ported to open.mp, this check didn't get to port over
I'll take a look at it and see if it should be done in pawn.raknet or open.mp

@bakunawa01
Copy link
Author

Fixed/doesn't occur anymore with the latest nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nightly
Projects
None yet
Development

No branches or pull requests

4 participants