Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New State Machine Diagram #530

Merged
merged 9 commits into from
Jun 26, 2020

Conversation

schnuerle
Copy link
Member

Explain pull request

Adding the new State Machine Diagram, placing it in the general_information file and removing the old diagram.

Also removed some 'notes' that were in the file, which I assumed were placeholders. We may need to capture those discussions elsewhere.

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • agency
  • policy
  • provider

Additional context

Closes issue #524.

@schnuerle schnuerle added the documentation documentation change can be for code and/or markdown pages label Jun 25, 2020
@schnuerle schnuerle requested a review from a team as a code owner June 25, 2020 19:09
@schnuerle schnuerle linked an issue Jun 25, 2020 that may be closed by this pull request
@schnuerle schnuerle added this to the 1.0.0 milestone Jun 25, 2020
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Very helpful to have inline.

One minor addition is to link to the Google Docs version, so anyone can create a copy and make updates from there, if needed.

@schnuerle
Copy link
Member Author

schnuerle commented Jun 26, 2020

I added a link to the Google Slides source file. Ready for review and merge.

general-information.md Outdated Show resolved Hide resolved
marie-x
marie-x previously approved these changes Jun 26, 2020
Copy link
Collaborator

@marie-x marie-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thekaveman
thekaveman previously approved these changes Jun 26, 2020
@schnuerle schnuerle dismissed stale reviews from thekaveman and marie-x via 07bfc14 June 26, 2020 20:22
@schnuerle schnuerle removed the request for review from HenriJ June 26, 2020 20:23
@schnuerle schnuerle merged commit 8a9cedf into openmobilityfoundation:dev Jun 26, 2020
@schnuerle schnuerle deleted the ms-state-diagram branch June 30, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation change can be for code and/or markdown pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include state machine diagram in Vehicle State docs
3 participants