Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify types for Provider query parameters #352

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

zaksoup
Copy link
Contributor

@zaksoup zaksoup commented Aug 14, 2019

Introduction

Hi, I'm Zak and I joined the team at Remix a few weeks ago. I'm excited to work with the MDS community!

Explanation

In MDS Provider it is implied that all references to timestamps should be made using milliseconds since unix epoch. The sections of the provider README for query parameters do not explicitly state types for query parameters. This change formats the explanations of query parameters to match the table specification for returned data and explicitly set types for each parameter.

Is this a breaking change

Providers who assumed the query parameter types were ambiguous may have to update their code if they were using seconds since unix epoch instead of millisconds.

Provider or agency?

Provider.

* Conclusively specify types for query parameters
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification, thank you!

@hunterowens hunterowens added this to the 0.4.0 milestone Aug 28, 2019
@hunterowens hunterowens merged commit cfd6d37 into openmobilityfoundation:dev Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants