Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports endpoint - START_DATE clarification #876

Closed
Mu-yi-Zhou opened this issue Aug 18, 2023 · 4 comments · Fixed by #883
Closed

Reports endpoint - START_DATE clarification #876

Mu-yi-Zhou opened this issue Aug 18, 2023 · 4 comments · Fixed by #883
Assignees
@schnuerle
Labels
minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Milestone
2.0.1

Comments

@Mu-yi-Zhou
Copy link

Please clarify START_DATE of the REPORTS endpoint https://github.com/openmobilityfoundation/mobility-data-specification/blob/main/data-types.md#reports

'Start date of trip the data row, ISO 8601 date format, i.e. YYYY-MM-DD' looks confusing.
@schnuerle
Copy link
Member

I think there is a typo there, it should say "Start date of the Trip data row, in ISO 8601 date format, i.e. YYYY-MM-DD". We can correct in the 2.0.1 release.

@schnuerle schnuerle added this to the 2.0.1 milestone Sep 1, 2023
@schnuerle schnuerle added the minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update. label Sep 1, 2023
@schnuerle
Copy link
Member

If you can make a PR for this change, that would be helpful, and you'd be listed as a GitHub contributor. We are looking at creating a 2.0.1 release soon for all open issues and PRs tagged with the 2.0.1 Milestone. If not I will create the PR.

@schnuerle schnuerle self-assigned this Oct 26, 2023
@schnuerle
Copy link
Member

I can handle making this change when we finalize the 2.0.1 release work.

@schnuerle schnuerle mentioned this issue Oct 30, 2023
Merged
@schnuerle schnuerle linked a pull request Oct 30, 2023 that will close this issue
Reworded comment for start_date in Reports #883
Merged
@schnuerle
Copy link
Member

Closed with PR #883 883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schnuerle schnuerle

Labels
minor update A change that is minor and should require little discussion, or is a maintenance/readme/typo update.
Projects
None yet
Milestone
2.0.1
Development

Successfully merging a pull request may close this issue.

Reworded comment for start_date in Reports openmobilityfoundation/mobility-data-specification
2 participants
@schnuerle @Mu-yi-Zhou