You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In the policy README, rule_units is amount for a rate rule type, but it could be a unit of time instead if the rate rule has a recurrence of each_time_unit or per_complete_time_unit.
Describe the solution you'd like
Get rid of amount as a valid value for rule_units. There doesn't seem to be much point in having rule_units have a value of amount just for rate rules that recur only once.
Is this a breaking change
I don't think this is breaking. If you write a recurring rate rule, you already have to set rule_units to some sort of time unit to have the rule make sense in the first place.
No, not breaking
Impacted Spec
For which spec is this feature being requested?
policy
Describe alternatives you've considered
We could leave it as is, but it seems very confusing to me.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
In the policy README,
rule_units
isamount
for a rate rule type, but it could be a unit of time instead if the rate rule has a recurrence ofeach_time_unit
orper_complete_time_unit
.Describe the solution you'd like
Get rid of
amount
as a valid value forrule_units
. There doesn't seem to be much point in havingrule_units
have a value ofamount
just for rate rules that recur only once.Is this a breaking change
I don't think this is breaking. If you write a recurring rate rule, you already have to set
rule_units
to some sort of time unit to have the rule make sense in the first place.Impacted Spec
For which spec is this feature being requested?
policy
Describe alternatives you've considered
We could leave it as is, but it seems very confusing to me.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: