Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with State Machine Diagram and Table #559

Closed
schnuerle opened this issue Jul 30, 2020 · 1 comment · Fixed by #558 or #560
Closed

Issues with State Machine Diagram and Table #559

schnuerle opened this issue Jul 30, 2020 · 1 comment · Fixed by #558 or #560
Labels
bug Something isn't working Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram
Milestone
1.0.0

Comments

@schnuerle
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

I discovered some discrepancies between the State Machine Diagram and the Vehicle State Events late last week when reviewing 1.0.0. Items were missing from both the table and the diagram after cross referencing them. Those were fixed in these three commits to the release-1.0.0 branch as part of the release review process.

There are some other new issues discovered with the 'unspecified' event type reason and the 'unknown' event state. These are being addressed in PR #558.

To Reproduce
Steps to reproduce the behavior:

See the current table and chart in the branch.

Expected behavior
A clear and concise description of what you expected to happen.

Revise the table and chart to be accurate, then update the schemas.

Additional context
Add any other context about the problem here.
@schnuerle schnuerle added this to the 1.0.0 milestone Jul 30, 2020
@schnuerle schnuerle added bug Something isn't working State Machine Changes in the vehicle state events and state machine diagram labels Jul 30, 2020
@schnuerle schnuerle linked a pull request Jul 30, 2020 that will close this issue
Updated Unknown/Unspecified State Transitions #558
Merged
@schnuerle schnuerle added the Schema Implications for JSON Schema or OpenAPI label Jul 30, 2020
@schnuerle
Copy link
Member Author

PR #558 is merged.

Now need some updates to the schemas. Asking for help on this from @thekaveman.

@schnuerle schnuerle linked a pull request Jul 31, 2020 that will close this issue
Add 'unspecified' events to some schema states #560
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Schema Implications for JSON Schema or OpenAPI State Machine Changes in the vehicle state events and state machine diagram
Projects
None yet
Milestone
1.0.0
1 participant
@schnuerle