Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix associated_trip schema inconsistency in 0.3.2 #347

Closed
rf- opened this issue Jul 23, 2019 · 5 comments
Closed

Fix associated_trip schema inconsistency in 0.3.2 #347

rf- opened this issue Jul 23, 2019 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@rf-
Copy link
Contributor

rf- commented Jul 23, 2019

When I submitted #297, I was under the impression that the existing JSON schema allowed an associated_trip value for any event_type_reason. It turns out that this is incorrect and the schema only allows an associated_trip for user_pick_up and user_drop_off events. If an event with a different reason has an associated_trip, both branches of the oneOf clause are true and the schema validation fails.

Now that the spec unambiguously states that any event can have an associated_trip if it ends a trip, we should update the schema to be consistent with this. I'm not sure how schema-only changes have been handled w/r/t the versioning/release process so far.

@hunterowens hunterowens added the bug Something isn't working label Aug 5, 2019
@hunterowens hunterowens added this to the 0.4.0 milestone Aug 5, 2019
@hunterowens
Copy link
Collaborator

yeah! schema only fixes have been treated as breaking in the past IIRC, but we should def fix this in time for 0.4.0 and perhaps consider an out of cycle patch release of 0.3.3 series.

(also sorry for not catching this sooner, I was out of pocket for a week).

Can you submit a PR and then @thekaveman and I can figure out what to with it

@thekaveman
Copy link
Collaborator

On the call today, the consensus from the group was that it is OK to wait for 0.4.0 to fix this.

If anyone has a different opinion, speak up on this issue ASAP!

@marie-x
Copy link
Collaborator

marie-x commented Sep 18, 2019

What other events besides user_drop_off can end a trip?

@rf-
Copy link
Contributor Author

rf- commented Sep 18, 2019

The classic example has been unavailable/low_battery, for the case where a trip ends involuntarily because the battery runs out and there’s no period of availability in between. This could also apply to maintenance.

@hunterowens
Copy link
Collaborator

fixed in #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants