Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNPOps 0.4 #86

Closed
raimis opened this issue Mar 2, 2023 · 12 comments
Closed

NNPOps 0.4 #86

raimis opened this issue Mar 2, 2023 · 12 comments
Assignees

Comments

@raimis
Copy link
Contributor

raimis commented Mar 2, 2023

It is time for the next release with:

Especially the PBC fix (#83). Does anybody working on something and wants to include it?

Ping: @peastman @RaulPPelaez @sef43

@raimis raimis self-assigned this Mar 2, 2023
@peastman
Copy link
Member

peastman commented Mar 2, 2023

Sounds good to me.

@RaulPPelaez
Copy link
Contributor

I would like to test this #80 a bit more.
For this #84 I say we jump straight to torch 2.0, probably solving 1.13 in the process.
Lets make 0.4 now.

@sef43
Copy link
Contributor

sef43 commented Mar 3, 2023

yep go ahead!

@raimis
Copy link
Contributor Author

raimis commented Mar 3, 2023

A release is created: https://github.com/openmm/NNPOps/releases/tag/v0.4

Now, let's see if conda-forge is going to pick it up automatically.

@raimis
Copy link
Contributor Author

raimis commented Mar 3, 2023

@raimis
Copy link
Contributor Author

raimis commented Mar 3, 2023

The package builds fail because of a tolerance issue with the new tests.

@sef43
Copy link
Contributor

sef43 commented Mar 6, 2023

yeah it is failing the tolerance test (which pass on the github actions CI which run on this repo) grad_error = 0.0074 fails in the assert(grad_error < 7e-3). I can reduced the tolerance to assert(grad_error < 8e-3) or even 1e-2. These seem like reasonably loose tolerances to me, are these what we expect from float32 precision gradient calculations? @raimis @peastman

@raimis
Copy link
Contributor Author

raimis commented Mar 6, 2023

I'm working on that.

@raimis
Copy link
Contributor Author

raimis commented Mar 6, 2023

Packages are available: https://anaconda.org/conda-forge/nnpops/files?version=0.4

@raimis
Copy link
Contributor Author

raimis commented Mar 6, 2023

@jchodera could you tweet about the release (https://github.com/openmm/NNPOps/releases/tag/v0.4)

@jchodera
Copy link
Member

jchodera commented Mar 7, 2023

@raimis
Copy link
Contributor Author

raimis commented Mar 7, 2023

Done!

@raimis raimis closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants