Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom PyTorch operations #3

Closed
4 of 5 tasks
raimis opened this issue Sep 18, 2020 · 5 comments
Closed
4 of 5 tasks

Custom PyTorch operations #3

raimis opened this issue Sep 18, 2020 · 5 comments

Comments

@raimis
Copy link
Contributor

raimis commented Sep 18, 2020

Requirements and progress of the custom operations for PyTorch.

Requirements:

  • ANI symmetry functions with adjustable parameters
  • Derivatives with respect to atomic coordinates
  • Compatible with TorchScript
  • CPU and GPU implementations
  • Conda package

Relevant documentation:

@raimis
Copy link
Contributor Author

raimis commented Sep 18, 2020

For us (@raimis, @stefdoerr @giadefa), this functionally is the highest priority in short term. In the past, I have worked a bit with the PyTorch internals and will be able to contribute. @peastman what do you think?

@peastman
Copy link
Member

I have the first two of those done for CPU. Next on my list is the CUDA version.

My current plan for this repository is that it will be source code only, a collection of mostly independent classes that people can directly incorporate into their own projects. Do you want to start working on the PyTorch library? We should consider exactly what we want that to be. Perhaps a complete implementation of the potential that uses this library for the symmetry functions and standard PyTorch ops for the neural network part?

@raimis
Copy link
Contributor Author

raimis commented Sep 21, 2020

I'm talking just about the bindings to PyTorch, so the operations in this library can be used directly form PyTorch.

@peastman
Copy link
Member

Sounds like a good first step.

@raimis raimis mentioned this issue Sep 25, 2020
14 tasks
@raimis
Copy link
Contributor Author

raimis commented Oct 1, 2021

Everything is completed here, except the conda package (#26).

@raimis raimis closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants