Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRST ROUND]Review Discussion #3

Open
vongosling opened this issue Jul 13, 2021 · 0 comments
Open

[FIRST ROUND]Review Discussion #3

vongosling opened this issue Jul 13, 2021 · 0 comments
Labels
discuss Very constructive and to be made wider open

Comments

@vongosling
Copy link
Contributor

vongosling commented Jul 13, 2021 •
edited
Loading

  • Spec descriptions should follow the rules: one-paragraph overview, parameter description, and use case.

  • Lack of the content negotiation in content types(application/json should be supported), we could provide multiple, weighted preferences:

Accept: application/vnd.openschema.v1+json; q=0.8, application/json; q=0.5

  • Error code should be defined. Or say, do we need to follow the RFC[1] ? In this way, we could provide the error validator template.

[1] https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.5.1
@vongosling vongosling added the enhancement New feature or request label Jul 13, 2021
@vongosling vongosling changed the title [FIRST ROUND]Review Suggestion [FIRST ROUND]Review Discussion Jul 13, 2021
@vongosling vongosling added discuss Very constructive and to be made wider open and removed enhancement New feature or request labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Very constructive and to be made wider open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vongosling