Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch DAGMC if not found in cmakelists.txt #3193

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jon-proximafusion
Copy link
Contributor

@jon-proximafusion jon-proximafusion commented Nov 11, 2024

Description

Marked as draft as this PR is mainly to check with @gonuke and @pshriwise if they would be keen on something like this?

Many other packages are included via submodule and they get smoothly installed during the compile so I was looking for ways of making the DAGMC install a bit smoother for users

I was just wondering if it is worth making the inclusion of DAGMC when compiling a little easier by automatically fetching the repo if it is requested and not found locally.

Changes like this to the cmakelists file could allow users to compile with dagmc like this

cmake .. -DOPENMC_USE_DAGMC=ON

This would provide a different route instead of cloning dagmc, compiling dagmc, cloning moab, compiling moab, passing directories to each cmake command etc.

ps this would need a small change in dagmc to fetch moab for this to work and changes in moab to make the repo more compatible with the fetch content. This issue is related

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant