Add a vessel composite surface with ellipsoids on top and bottom. #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith ellipsoids on top and bottom.
pshriwise
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks @nsedayilmaz! This is a nice addition and great application for the composite surface. I've made a few small comments here. We'll want to add some tests for this surface as well.
Co-authored-by: Patrick Shriwise <[email protected]>
Co-authored-by: Patrick Shriwise <[email protected]>
Add a test for ZVessel composite surface
paulromano
changed the title
paulromano
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
I did some refactoring on this branch to generalize it so it can be oriented in the x-, y-, or z-directions instead of just z. @pshriwise if you can take another quick look, I'll need your approval to merge. Thanks!
pshriwise
requested changes
Nov 9, 2024
openmc/model/surface_composite.py
Outdated
| _surface_names = ('cyl', 'plane_bottom', 'plane_top', 'bottom', 'top') | ||
|
|
||
| def __init__(self, r: float, p1: float, p2: float, h1: float, h2: float, | ||
| center: Sequence[float] = (0., 0.), axis='z', **kwargs): |
There was a problem hiding this comment.
Should there be a type hint for axis here?
|
Thank you both for working on this request! |
magnoxemo
pushed a commit
to magnoxemo/openmc
that referenced
this pull request
Nov 22, 2024
…enmc-dev#3168) Co-authored-by: Patrick Shriwise <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.