Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(potential bug) Use atomic add operations for incrementing source site rejection counters #3005

Open
gridley opened this issue May 14, 2024 · 0 comments
Labels

Comments

@gridley
Copy link
Contributor

gridley commented May 14, 2024

Bug Description

In #2916 it was mentioned that the source rejection counters, which are static variables, are not incremented in a threadsafe way. This has not resulted in any bugs so far, but may give behavior slightly different from what's expected. In most systems operations on 32 bit data are atomic in the first place so this hasn't been an issue. Rigorously, though, these should be atomic add operations.

This issue can be closed when OpenMP atomic statements are appropriately inserted for manipulating the source rejection counters, i.e. static variables which are related to EXTERNAL_SRC_REJECT_THRESHOLD.

@gridley gridley added the Bugs label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant