Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: deplete.export_to_materials to support multiple burnup_index #2120

Closed
shimwell opened this issue Jul 18, 2022 · 1 comment
Closed

Comments

@shimwell
Copy link
Member

Hi all,

I'm just making use of the nice depletion capabilities and in particular the Results.export_to_materials() method.

This method takes a burnup_index argument which identifies the time step to use.

Perhaps burnup_index could default to None and if left as None then all time steps could be returned?

Would this be a welcome addition? If so I can look into making a PR

Currently I'm looping through all the timesteps and calling export_to_materials for each step which isn't too inconvenient, so perhaps this extra flexibility is not needed.

@shimwell
Copy link
Member Author

shimwell commented Oct 4, 2022

solved in #2234 with the addition of get_material to StepResult

@shimwell shimwell closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant