Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep used to find .tendl files #82

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jun 5, 2023

Admittedly I've not tinkered with this repo for a while but while looking into the feasability of adding TENDL 2015/ 2017 and 2021 chain files I noticed this part of the code that looks up the transportable endf files. I think we can just grep for these files and don't need to have a hard coded list. Perhaps I am missing something here?

@paulromano
Copy link
Contributor

@shimwell The reason that we have that separate JSON file of transport nuclides is explained in the description of #41. TENDL itself includes >2000 incident neutron files and so the predetermined list represents a reasonable subset of nuclides (630) to use for depletion purposes.

If we get to the point where the depletion chain can list all possible reactions but a user has a way to specify a subset of nuclides/reactions they want to track during depletion, that would be a good point to switch over to the approach you've proposed here.

@shimwell
Copy link
Member Author

I guess all the nuclides and all the reactions is really going to blow up the memory. I guess we keep this PR in draft then just in case we get that filtering of depletion chain feature at a later date

@shimwell shimwell marked this pull request as draft July 18, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants