Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/user pass on cli #34

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Feature/user pass on cli #34

wants to merge 3 commits into from

Conversation

makosblade
Copy link
Contributor

@makosblade makosblade commented May 14, 2020 •
edited
Loading

This PR:

  • Depends on merging Fix/file based destinations #33
  • adds the ability to pass usernames and passwords per datalake on the command line
  • -usernames {"datalake1":"user","datalake2":"admin"}
  • -passwords {"datalake1":"notAPassword","datalake2:"admin"}

@makosblade makosblade mentioned this pull request May 14, 2020
Closed
@makosblade makosblade marked this pull request as draft May 14, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katherinebernstein katherinebernstein katherinebernstein approved these changes

@geekbeast geekbeast Awaiting requested review from geekbeast geekbeast is a code owner

@dbt dbt Awaiting requested review from dbt

@jason2e jason2e Awaiting requested review from jason2e

@jokedurnez jokedurnez Awaiting requested review from jokedurnez

@UnsungHero97 UnsungHero97 Awaiting requested review from UnsungHero97 UnsungHero97 will be requested when the pull request is marked ready for review UnsungHero97 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makosblade @katherinebernstein @geekbeast