Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] sidecarSet support namespace selector #948

Closed
zmberg opened this issue Apr 11, 2022 · 3 comments
Closed

[feature request] sidecarSet support namespace selector #948

zmberg opened this issue Apr 11, 2022 · 3 comments
Assignees
@FillZpp @zmberg
Labels
kind/enhancement New feature or request kind/feature-request kind/good-idea Good Idea
Milestone
v1.4

Comments

@zmberg
Copy link
Member

zmberg commented Apr 11, 2022

What would you like to be added:
Support for injecting sidecar via namespace selector, e.g., injecting envoy container by giving ns istio-injection=enabled

Why is this needed:
@zmberg
Copy link
Member Author

zmberg commented Apr 11, 2022

/assign @zmberg

@hantmac hantmac mentioned this issue May 7, 2022
Closed
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 10, 2022
@FillZpp FillZpp removed the wontfix This will not be worked on label Jul 11, 2022
@hantmac hantmac mentioned this issue Jul 17, 2022
Closed
@stale
Copy link

stale bot commented Oct 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 9, 2022
@stale stale bot closed this as completed Oct 16, 2022
@zmberg zmberg reopened this Feb 15, 2023
@stale stale bot removed the wontfix This will not be worked on label Feb 15, 2023
@zmberg zmberg added this to the v1.4 milestone Feb 15, 2023
@zmberg zmberg added the kind/enhancement New feature or request label Feb 15, 2023
@zmberg zmberg mentioned this issue Feb 16, 2023
Merged
@zmberg zmberg added the kind/good-idea Good Idea label Feb 22, 2023
@zmberg zmberg closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FillZpp FillZpp

@zmberg zmberg

Labels
kind/enhancement New feature or request kind/feature-request kind/good-idea Good Idea
Projects
None yet
Milestone
v1.4
2 participants
@FillZpp @zmberg