Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Bump Kubernetes dependencies to 1.22 #871

Closed
FillZpp opened this issue Dec 30, 2021 · 6 comments · Fixed by #915
Closed

[feature request] Bump Kubernetes dependencies to 1.22 #871

FillZpp opened this issue Dec 30, 2021 · 6 comments · Fixed by #915
Assignees

Comments

@FillZpp
Copy link
Member

FillZpp commented Dec 30, 2021

What would you like to be added:
Bump Kubernetes dependencies to v1.22.5 as well as controller-runtime to v0.10.3.

Note that it is only the code dependencies, Kruise can still be installed in clusters with Kubernetes version >= 1.16.

Why is this needed:
We have to update K8s dependencies so that users can use new fields in pod template. We also need the UnsafeDisableDeepCopy released in controller-runtime v.0.10.

You can do this following the document BUMP_KUBERNETS_VERSION.md.

@Jeffwan
Copy link

Jeffwan commented Feb 25, 2022

@FillZpp Can we bump master version to 1.23 directly?

@FillZpp
Copy link
Member Author

FillZpp commented Feb 25, 2022

@FillZpp Can we bump master version to 1.23 directly?

@Jeffwan Hi, usually we choose the even number of the K8s version, e.g., 1.20, 1.22. Emm... Which feature of 1.23 do you need?

@Jeffwan
Copy link

Jeffwan commented Feb 26, 2022

@FillZpp 1.22 works fine as well. 1.23 was officially released last Dec so I am thinking it's better to catch up the upstream latest version. Another thing is the cluster we use kurise on is 1.23 with default CRI v1 and PodSecurity stuff and we may replace client-go internally. Upgrade to 1.23 makes our life easier but this is definitely optional for community.

If the community has conventional versioning, it works for us. Do you have a plan for 1.22 upgrade?

@FillZpp
Copy link
Member Author

FillZpp commented Feb 28, 2022

@Jeffwan Understand, thanks for your feedback.

My thoughts: even if Kruise bump K8s dependency to 1.23, it can still use CRI v1alpha2 to be compatible with the K8s clusters in old versions. So generally you don't have to care about its dependency version, unless you need to use some new fields of PodSpec in Kruise workload template.

Do you have a plan for 1.22 upgrade?

@veophi is working on this https://github.com/veophi/kruise/tree/bump-1.22 . But I'm not sure if it will be submitted and merged before the incoming v1.1 is released.

@wilsonwang371
Copy link

@Jeffwan Understand, thanks for your feedback.

My thoughts: even if Kruise bump K8s dependency to 1.23, it can still use CRI v1alpha2 to be compatible with the K8s clusters in old versions. So generally you don't have to care about its dependency version, unless you need to use some new fields of PodSpec in Kruise workload template.

Do you have a plan for 1.22 upgrade?

@veophi is working on this https://github.com/veophi/kruise/tree/bump-1.22 . But I'm not sure if it will be submitted and merged before the incoming v1.1 is released.

We are actually using the field that is not in 1.20 and as a result, these fields are not passed down from advanced sts to created pods.

Is https://github.com/veophi/kruise/tree/bump-1.22 ready to use, did we test this?

@FillZpp
Copy link
Member Author

FillZpp commented Mar 1, 2022

@wilsonwang371 Thanks, it is not ready to use. But since you gays need it for new fields and @veophi may be busy these days, I have completed the upgrade based on it and submitted #915 . You can test with the branch if you need. Besides, we are planning to publish a new v1.1 release for OpenKruise in mid March and this should be included in that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants