Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] SidecarSet支持查看管控范围内Pod上的Sidecar当前版本 #1005

Closed
Reason94 opened this issue Jun 23, 2022 · 3 comments
Assignees
Labels
kind/feature-request wontfix This will not be worked on

Comments

@Reason94
Copy link

What would you like to be added:

  • SidecarSet升级完成后,快速了解哪些pod已经升级成新版本了
  • SidecarSet管控范围内,各个Pod的sidecar版本,可按版本筛选pod

Why is this needed:
用于Paas平台集成,查看下某次金丝雀发布后哪些pod已经升级,以及本sidecar管控范围内pod上的sidecar版本

** 个人思路**:
sidecarset 像cloneset一样,增加labels信息,此类label会被写入pod的labels部分。
通过Selector机制快速查询

@zmberg
Copy link
Member

zmberg commented Jun 23, 2022

@Reason94 look at this pr #993, If add the version label here, eg. kruise.io/sidecar-version: v1 ,it should meet your needs.

@Reason94
Copy link
Author

@Reason94 look at this pr #993, If add the version label here, eg. kruise.io/sidecar-version: v1 ,it should meet your needs.

It seems that it can solve my needs. When will it be released?

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 21, 2022
@stale stale bot closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants