From 56517c7f399fc03d634def17ebcac36d54b0ac6a Mon Sep 17 00:00:00 2001 From: hantmac Date: Tue, 2 Apr 2024 22:51:03 +0800 Subject: [PATCH] fix mdl ci Signed-off-by: hantmac --- .../20240309-cloneset-support-progressDeadlineSeconds.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md b/docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md index 34885a62f0..2d8e068f9d 100644 --- a/docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md +++ b/docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md @@ -23,7 +23,6 @@ Table of Contents - [2. The behavior of progressDeadlineSeconds](#2the-behavior-of-progressDeadlineSeconds) - [3. handle the logic](#2handle-the-logic) - ## Motivation `.spec.progressDeadlineSeconds` is an optional field in Deployment that specifies the number of seconds one wants to wait for their Deployment to progress before the system reports back that the Deployment has failed progressing. @@ -35,10 +34,10 @@ reason: ProgressDeadlineExceeded ``` This is useful for users to control the progress of the deployment. -So we should add support for `progressDeadlineSeconds` in CloneSet as well. +So we should add support for `progressDeadlineSeconds` in CloneSet as well. ## Proposal -Firstly, add the `progressDeadlineSeconds` field to the CloneSetSpec. +Firstly, add the `progressDeadlineSeconds` field to the CloneSetSpec. Then add the handle logic in cloneSet controller to handle the `progressDeadlineSeconds` field. ### 1. add .spec.progressDeadlineSeconds field @@ -72,7 +71,7 @@ Here are two possible interpretations of `progressDeadlineSeconds` in the contex These interpretations are open for discussion and we welcome feedback from the community to make a decision. ### 3. handle the logic -In cloneset controller, we should add the logic to handle the `progressDeadlineSeconds` field. +In cloneset controller, we should add the logic to handle the `progressDeadlineSeconds` field. ```go func (c *CloneSetController) syncCloneSetStatus(cloneSet *appsv1alpha1.CloneSet, newStatus *appsv1alpha1.CloneSetStatus) error { ...