-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project charter review for AMP #552
Comments
The content of the charter + GOVERNANCE.md look good to me. I think though that to be consistent with what's been subject to review by the CPC/and possibly Board in the past changes to both the CHARTER.md and GOVERNANCE.md would need approval by the CPC. If its ok to update the char CHARTER.md to indicated that changes to both doc's require approval then that would be the only change necessary. Otherwise it probably needs a deeper discussion of what needs review/approval by the CPC/possibly board because if it's only the charter.md as written that would need approval as written then the CPC has a review/signoff on effectively almost nothing. |
Looks pretty good. My only concerns are the way that the single-employer limits are phrased in the governance doc:
Is the limit for the AC a hard limit, or is that too aspirational? If it's meant to be a hard limit, using "must" or "may" instead of "should" would make that clearer. To be clear, I'm happy to +1 this, just find these expressions a bit... fuzzy. |
As a result of the new requirements added in today's CPC call, please also approve the related pull request to GOVERNANCE.md: ampproject/meta#55 |
@eemeli wrote:
Thanks for your comment, @eemeli. With my standards background, I read this as RFC 2119 language which defines "should" as:
For context, the TSC is slightly unbalanced right now but is actively working towards achieving this goal. I think we should revisit this wording when the project attempts to graduate from Growth to Impact. Would that work for you? |
@joesepi & @mhdawson: I made the requested changes to the charter. I'm additionally requesting review of the related changes to |
+1 for approving charter/governance in the current form |
+1 for approving charter/governance in the current form |
Two approvals. No objections. Good to go. |
AMP is getting closer to completing its onboarding checklist. (For those of you who are interested, progress on the various items are tracked in a dedicated project board.)
AMP Charter is now ready to be reviewed by the CPC.
It currently sits as a pull request in AMP's meta repository: ampproject/meta#56 and we'd appreciate the CPC's review.
As a result of the new requirements added by the CPC, please also review the related pull request to GOVERNANCE.md: ampproject/meta#55.
The text was updated successfully, but these errors were encountered: